chore: refactor command structure (#587)

* refactor cli harness Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * use single configuration for ui Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * remove remaining viper rules * add basic CLI tests Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * separate cmd and api concerns for keybindings * plumb through context for future logging * port to using internal logger * internalize non-analysis path * encapsulate ui with clio * merge runtime into cmd + add adapter package * support legacy config shapes * improve testing around formatting * fix log-ui interactions * fix linting and update test snapshots * fix initialization of tree viewmodel * indent files in report * fix build * setup qemu and buildx in release workflow * show formatted output in CI * add cli tests for source flag * add default ci config cli test --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

Alex Goodman committed on Apr 8, 2025, 04:19 PM

Showing 156 changed files +13845 additions -6991 deletions

M .dockerignore +1 -1

M .github/workflows/release.yaml +6

M .gitignore +5

M .goreleaser.yaml +10 -1

M Taskfile.yaml +13 -2

D cmd/analyze.go -73

D cmd/build.go -38

D cmd/ci.go -37

A cmd/dive/cli/cli.go +53

A cmd/dive/cli/cli_build_test.go +91

A cmd/dive/cli/cli_ci_test.go +51

A cmd/dive/cli/cli_config_test.go +17

A cmd/dive/cli/cli_json_test.go +29

A cmd/dive/cli/cli_load_test.go +105

A cmd/dive/cli/cli_test.go +175

A cmd/dive/cli/internal/command/adapter/analyzer.go +68

A cmd/dive/cli/internal/command/adapter/evaluator.go +48

A cmd/dive/cli/internal/command/adapter/exporter.go +63

A cmd/dive/cli/internal/command/adapter/resolver.go +91

A cmd/dive/cli/internal/command/build.go +46

A cmd/dive/cli/internal/command/ci/evaluator.go +308

A cmd/dive/cli/internal/command/ci/evaluator_test.go +198

A cmd/dive/cli/internal/command/ci/rule.go +47

A cmd/dive/cli/internal/command/ci/rules.go +196

A cmd/dive/cli/internal/command/export/export.go +86

A cmd/dive/cli/internal/command/export/export_test.go +19

A cmd/dive/cli/internal/command/export/main_test.go +68

A cmd/dive/cli/internal/command/export/testdata/snapshots/export_test.snap +4665

A cmd/dive/cli/internal/command/root.go +99

A cmd/dive/cli/internal/options/analysis.go +75

A cmd/dive/cli/internal/options/application.go +32

A cmd/dive/cli/internal/options/ci.go +105

A cmd/dive/cli/internal/options/ci_rules.go +73

A cmd/dive/cli/internal/options/export.go +40

A cmd/dive/cli/internal/options/ui.go +18

A cmd/dive/cli/internal/options/ui_diff.go +39

A cmd/dive/cli/internal/options/ui_filetree.go +43

A cmd/dive/cli/internal/options/ui_keybindings.go +178

A cmd/dive/cli/internal/options/ui_layers.go +20

A cmd/dive/cli/internal/ui/no_ui.go +30

A cmd/dive/cli/internal/ui/v1.go +176

A cmd/dive/cli/internal/ui/v1/app/app.go +136

R cmd/dive/cli/internal/ui/v1/app/controller.go +52 -61

R cmd/dive/cli/internal/ui/v1/app/job_control_other.go +1 -1

R cmd/dive/cli/internal/ui/v1/app/job_control_unix.go +1 -1

A cmd/dive/cli/internal/ui/v1/config.go +67

R cmd/dive/cli/internal/ui/v1/format/format.go

R cmd/dive/cli/internal/ui/v1/key/binding.go +6 -44

A cmd/dive/cli/internal/ui/v1/key/config.go +100

R cmd/dive/cli/internal/ui/v1/layout/area.go

R cmd/dive/cli/internal/ui/v1/layout/compound/layer_details_column.go +13 -19

R cmd/dive/cli/internal/ui/v1/layout/layout.go

R cmd/dive/cli/internal/ui/v1/layout/location.go

R cmd/dive/cli/internal/ui/v1/layout/manager.go +5 -6

R cmd/dive/cli/internal/ui/v1/layout/manager_test.go

R cmd/dive/cli/internal/ui/v1/view/cursor.go

R cmd/dive/cli/internal/ui/v1/view/debug.go +16 -16

R cmd/dive/cli/internal/ui/v1/view/filetree.go +62 -59

R cmd/dive/cli/internal/ui/v1/view/filter.go +24 -26

R cmd/dive/cli/internal/ui/v1/view/image_details.go +29 -24

R cmd/dive/cli/internal/ui/v1/view/layer.go +36 -34

A cmd/dive/cli/internal/ui/v1/view/layer_change_listener.go +7

R cmd/dive/cli/internal/ui/v1/view/layer_details.go +18 -14

R cmd/dive/cli/internal/ui/v1/view/renderer.go

R cmd/dive/cli/internal/ui/v1/view/status.go +22 -21

A cmd/dive/cli/internal/ui/v1/view/views.go +67

A cmd/dive/cli/internal/ui/v1/viewmodel/config.go +1

R cmd/dive/cli/internal/ui/v1/viewmodel/filetree.go +34 -36

R cmd/dive/cli/internal/ui/v1/viewmodel/filetree_test.go +80 -56

R cmd/dive/cli/internal/ui/v1/viewmodel/layer_compare.go

R cmd/dive/cli/internal/ui/v1/viewmodel/layer_selection.go

R cmd/dive/cli/internal/ui/v1/viewmodel/layer_set_state.go

R cmd/dive/cli/internal/ui/v1/viewmodel/layer_set_state_test.go

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileShowAggregateChanges.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeDirCollapse.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeDirCollapseAll.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeDirCursorRight.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeFilterTree.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeGoCase.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeHideAddedRemovedModified.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeHideTypeWithFilter.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeHideUnmodified.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeNoAttributes.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreePageDown.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreePageUp.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeRestrictedHeight.txt

R cmd/dive/cli/internal/ui/v1/viewmodel/testdata/TestFileTreeSelectLayer.txt

A cmd/dive/cli/testdata/config/dive-ci-legacy.yaml +4

A cmd/dive/cli/testdata/default-ci-config/.dive-ci +9

A cmd/dive/cli/testdata/dive-enable-ci.yaml +10

A cmd/dive/cli/testdata/image-multi-layer-containerfile/Containerfile +13

A cmd/dive/cli/testdata/image-multi-layer-containerfile/dive-pass.yaml +10

A cmd/dive/cli/testdata/image-multi-layer-containerfile/example.md +3

A cmd/dive/cli/testdata/image-multi-layer-containerfile/overwrite.md +3

A cmd/dive/cli/testdata/image-multi-layer-dockerfile/Dockerfile +13

A cmd/dive/cli/testdata/image-multi-layer-dockerfile/dive-fail.yaml +3

A cmd/dive/cli/testdata/image-multi-layer-dockerfile/dive-pass.yaml +5

A cmd/dive/cli/testdata/image-multi-layer-dockerfile/example.md +3

A cmd/dive/cli/testdata/image-multi-layer-dockerfile/overwrite.md +3

A cmd/dive/cli/testdata/invalid/Dockerfile +2

A cmd/dive/cli/testdata/snapshots/cli_build_test.snap +137

A cmd/dive/cli/testdata/snapshots/cli_ci_test.snap +78

A cmd/dive/cli/testdata/snapshots/cli_config_test.snap +127

A cmd/dive/cli/testdata/snapshots/cli_json_test.snap +4432

A cmd/dive/cli/testdata/snapshots/cli_load_test.snap +144

R cmd/dive/main.go +26 -12

D cmd/root.go -220

D cmd/version.go -34

M dive/filetree/comparer.go +1 -4

M dive/filetree/efficiency.go +6 -8

M dive/filetree/file_info.go +5 -5

M dive/filetree/file_node.go +2 -2

M dive/filetree/file_tree.go +4 -5

M dive/filetree/file_tree_test.go +2 -3

A dive/image/analysis.go +47

D dive/image/analyzer.go -20

M dive/image/docker/archive_resolver.go +5 -4

M dive/image/docker/cli.go +7 -2

M dive/image/docker/config.go +2 -3

M dive/image/docker/engine_resolver.go +19 -14

M dive/image/docker/image_archive.go +4 -3

M dive/image/docker/manifest.go +2 -3

M dive/image/docker/testing.go +12 -14

M dive/image/image.go +3 -30

M dive/image/podman/build.go -1

M dive/image/podman/cli.go +11 -4

M dive/image/podman/resolver.go +8 -8

M dive/image/podman/resolver_unsupported.go +4 -3

M dive/image/resolver.go +9 -3

M go.mod +49 -12

M go.sum +105 -12

A internal/bus/bus.go +19

A internal/bus/event/event.go +21

A internal/bus/event/parser/parsers.go +106

A internal/bus/event/payload/explore.go +8

A internal/bus/event/payload/generic.go +48

A internal/bus/helpers.go +63

A internal/log/log.go +79

R internal/utils/format.go -6

R internal/utils/view.go +5 -4

D runtime/ci/evaluator.go -186

D runtime/ci/evaluator_test.go -59

D runtime/ci/reference_file.go -7

D runtime/ci/rule.go -168

D runtime/event.go -31

D runtime/export/export.go -66

D runtime/export/export_test.go -4690

D runtime/export/file_reference.go -7

D runtime/export/image.go -8

D runtime/export/layer.go -14

D runtime/options.go -17

D runtime/run.go -160

D runtime/run_test.go -314

D runtime/ui/app.go -165

D runtime/ui/view/layer_change_listener.go -5

D runtime/ui/view/views.go -85