1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { FlatCompat } from '@eslint/eslintrc';
import js from '@eslint/js';
import emberEslintParser from 'ember-eslint-parser';
import ember from 'eslint-plugin-ember';
import emberConcurrency from 'eslint-plugin-ember-concurrency';
import preferLet from 'eslint-plugin-prefer-let';
import prettier from 'eslint-plugin-prettier';
import eslintPluginUnicorn from 'eslint-plugin-unicorn';
import globals from 'globals';
const filename = fileURLToPath(import.meta.url);
const dirname = path.dirname(filename);
const compat = new FlatCompat({
baseDirectory: dirname,
recommendedConfig: js.configs.recommended,
allConfig: js.configs.all,
});
export default [
eslintPluginUnicorn.configs.recommended,
{
ignores: [
'.git/**/*',
'crates/',
'playwright-report/',
'svelte/',
'target/',
'test-results/',
'tmp/',
// unconventional js
'blueprints/*/files/',
'vendor/',
// compiled output
'dist/',
'tmp/',
// dependencies
'bower_components/',
'node_modules/',
// misc
'coverage/',
'!**/.*',
// ember-try
'.node_modules.ember-try/',
'bower.json.ember-try',
'package.json.ember-try',
],
},
...compat.extends(
'eslint:recommended',
'plugin:ember/recommended',
'plugin:qunit/recommended',
'plugin:qunit-dom/recommended',
'plugin:prettier/recommended',
),
{
plugins: {
ember,
'ember-concurrency': emberConcurrency,
'prefer-let': preferLet,
prettier,
},
languageOptions: {
globals: {
...globals.browser,
},
parser: emberEslintParser,
ecmaVersion: 2018,
sourceType: 'module',
parserOptions: {
requireConfigFile: false,
babelOptions: {
plugins: [
[
'@babel/plugin-proposal-decorators',
{
decoratorsBeforeExport: true,
},
],
],
},
},
},
rules: {
// it's fine to use `return` without a value and rely on the implicit `undefined` return value
'getter-return': 'off',
'prefer-const': 'off',
'prefer-let/prefer-let': 'error',
'prettier/prettier': 'error',
// disabled because we still use `this.set()` in a few places and it works just fine
'ember/classic-decorator-no-classic-methods': 'off',
// disabled because the alternatives are currently not worth the additional complexity
'ember/no-array-prototype-extensions': 'off',
'ember-concurrency/no-perform-without-catch': 'warn',
'ember-concurrency/require-task-name-suffix': 'error',
// disabled because of false positives in `assert.rejects()` calls
'qunit/require-expect': 'off',
// disabled because of false positives related to ember-concurrency usage
'unicorn/consistent-function-scoping': 'off',
'unicorn/explicit-length-check': ['error', { 'non-zero': 'not-equal' }],
// disabled because it conflicts with Ember.js conventions
'unicorn/no-anonymous-default-export': 'off',
// disabled because of false positives related to `EmberArray`
'unicorn/no-array-for-each': 'off',
// disabled because `toReversed` is not "widely supported" yet
'unicorn/no-array-reverse': 'off',
// disabled because `toSorted` is not "widely supported" yet
'unicorn/no-array-sort': 'off',
// disabled because it is annoying in some cases...
'unicorn/no-await-expression-member': 'off',
// disabled because we need `null` since JSON has no `undefined`
'unicorn/no-null': 'off',
// disabled because this rule conflicts with prettier
'unicorn/no-nested-ternary': 'off',
// disabled because of unfixable false positives
'unicorn/prevent-abbreviations': 'off',
// disabled because we are targeting only browsers at the moment
'unicorn/prefer-global-this': 'off',
// disabled because we don't want to go all-in on ES6 modules for Node.js code yet
'unicorn/prefer-module': 'off',
// disabled because it seems unnecessary
'unicorn/prefer-number-properties': 'off',
// disabled because it seems unnecessary
'unicorn/prefer-reflect-apply': 'off',
// disabled because of false positives related to `EmberArray`
'unicorn/prefer-spread': 'off',
// disabled because it seems unnecessary
'unicorn/prefer-string-raw': 'off',
// disabled because of Sentry issues
'unicorn/prefer-string-replace-all': 'off',
// disabled because switch statements in JS are quite error-prone
'unicorn/prefer-switch': 'off',
// disabled because of false positives
'unicorn/consistent-destructuring': 'off',
'unicorn/filename-case': ['error', { case: 'kebabCase', ignore: ['^-'] }],
},
},
// test files
{
files: ['tests/**/*.js'],
rules: {
'unicorn/consistent-function-scoping': 'off',
'unicorn/prefer-dom-node-dataset': 'off',
},
},
// node files
{
files: [
'eslint.config.mjs',
'**/.template-lintrc.js',
'**/ember-cli-build.js',
'**/testem.js',
'blueprints/*/index.js',
'config/**/*.js',
'lib/*/index.js',
'script/**/*.mjs',
'server/**/*.js',
],
languageOptions: {
globals: {
...Object.fromEntries(Object.entries(globals.browser).map(([key]) => [key, 'off'])),
...globals.node,
},
ecmaVersion: 2018,
sourceType: 'script',
},
},
];