1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675//! Config hot-reload — diffs two `KernelConfig` instances and produces a `ReloadPlan`.
//!
//! **Hot-reload safe**: channels, skills, usage footer, web config, browser,
//! approval policy, cron settings, webhook triggers, extensions.
//!
//! **No-op** (informational only): log_level, language, mode.
//!
//! **Restart required**: api_listen, api_key, network, memory, default_model.
use openfang_types::config::{KernelConfig, ReloadMode};
use tracing::{info, warn};
// ---------------------------------------------------------------------------
// HotAction — what can be changed at runtime without restart
// ---------------------------------------------------------------------------
/// An individual action that can be applied at runtime (hot-reload).
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum HotAction {
/// Channel configuration changed — reload channel bridges.
ReloadChannels,
/// Skill configuration changed — reload skill registry.
ReloadSkills,
/// Usage footer mode changed.
UpdateUsageFooter,
/// Web config changed — rebuild web tools context.
ReloadWebConfig,
/// Browser config changed.
ReloadBrowserConfig,
/// Approval policy changed.
UpdateApprovalPolicy,
/// Cron max jobs changed.
UpdateCronConfig,
/// Webhook trigger config changed.
UpdateWebhookConfig,
/// Extension config changed.
ReloadExtensions,
/// MCP server list changed — reconnect MCP clients.
ReloadMcpServers,
/// A2A config changed.
ReloadA2aConfig,
/// Fallback provider chain changed.
ReloadFallbackProviders,
/// Provider base URL overrides changed.
ReloadProviderUrls,
}
// ---------------------------------------------------------------------------
// ReloadPlan — the output of diffing two configs
// ---------------------------------------------------------------------------
/// A categorized plan for applying config changes.
///
/// After building a plan via [`build_reload_plan`], callers inspect
/// `restart_required` to decide whether a full restart is needed or
/// the `hot_actions` can be applied in-place.
#[derive(Debug, Clone)]
pub struct ReloadPlan {
/// Whether a full restart is needed.
pub restart_required: bool,
/// Human-readable reasons why restart is required.
pub restart_reasons: Vec<String>,
/// Actions that can be hot-reloaded without restart.
pub hot_actions: Vec<HotAction>,
/// Fields that changed but are no-ops (informational only).
pub noop_changes: Vec<String>,
}
impl ReloadPlan {
/// Whether any changes were detected at all.
pub fn has_changes(&self) -> bool {
self.restart_required || !self.hot_actions.is_empty() || !self.noop_changes.is_empty()
}
/// Whether the plan can be applied without restart.
pub fn is_hot_reloadable(&self) -> bool {
!self.restart_required
}
/// Log a human-readable summary of the plan.
pub fn log_summary(&self) {
if !self.has_changes() {
info!("config reload: no changes detected");
return;
}
if self.restart_required {
warn!(
"config reload: restart required — {}",
self.restart_reasons.join("; ")
);
}
for action in &self.hot_actions {
info!("config reload: hot-reload action queued — {action:?}");
}
for noop in &self.noop_changes {
info!("config reload: no-op change — {noop}");
}
}
}
// ---------------------------------------------------------------------------
// build_reload_plan
// ---------------------------------------------------------------------------
/// Compare JSON-serialized forms of a field. Returns `true` when the
/// serialized representations differ (or if one side fails to serialize).
fn field_changed<T: serde::Serialize>(old: &T, new: &T) -> bool {
let old_json = serde_json::to_string(old).ok();
let new_json = serde_json::to_string(new).ok();
old_json != new_json
}
/// Diff two configurations and produce a reload plan.
///
/// The plan categorizes every detected change into one of three buckets:
///
/// 1. **restart_required** — the change touches something that cannot be
/// patched at runtime (e.g. the listen address or database path).
/// 2. **hot_actions** — the change can be applied without restarting.
/// 3. **noop_changes** — the change is informational; no action needed.
pub fn build_reload_plan(old: &KernelConfig, new: &KernelConfig) -> ReloadPlan {
let mut plan = ReloadPlan {
restart_required: false,
restart_reasons: Vec::new(),
hot_actions: Vec::new(),
noop_changes: Vec::new(),
};
// ----- Restart-required fields -----
if old.api_listen != new.api_listen {
plan.restart_required = true;
plan.restart_reasons.push(format!(
"api_listen changed: {} -> {}",
old.api_listen, new.api_listen
));
}
if old.api_key != new.api_key {
plan.restart_required = true;
plan.restart_reasons.push("api_key changed".to_string());
}
if old.network_enabled != new.network_enabled {
plan.restart_required = true;
plan.restart_reasons
.push("network_enabled changed".to_string());
}
// Network config (shared_secret, listen_addresses, etc.)
if field_changed(&old.network, &new.network) {
plan.restart_required = true;
plan.restart_reasons
.push("network config changed".to_string());
}
// Memory config (requires restarting SQLite connections)
if field_changed(&old.memory, &new.memory) {
plan.restart_required = true;
plan.restart_reasons
.push("memory config changed".to_string());
}
// Default model (driver needs recreation)
if field_changed(&old.default_model, &new.default_model) {
plan.restart_required = true;
plan.restart_reasons
.push("default_model changed".to_string());
}
// Home/data directory changes
if old.home_dir != new.home_dir {
plan.restart_required = true;
plan.restart_reasons.push(format!(
"home_dir changed: {:?} -> {:?}",
old.home_dir, new.home_dir
));
}
if old.data_dir != new.data_dir {
plan.restart_required = true;
plan.restart_reasons.push(format!(
"data_dir changed: {:?} -> {:?}",
old.data_dir, new.data_dir
));
}
// Vault config (encryption key derivation)
if field_changed(&old.vault, &new.vault) {
plan.restart_required = true;
plan.restart_reasons
.push("vault config changed".to_string());
}
// ----- Hot-reloadable fields -----
if field_changed(&old.channels, &new.channels) {
plan.hot_actions.push(HotAction::ReloadChannels);
}
if old.usage_footer != new.usage_footer {
plan.hot_actions.push(HotAction::UpdateUsageFooter);
}
if field_changed(&old.web, &new.web) {
plan.hot_actions.push(HotAction::ReloadWebConfig);
}
if field_changed(&old.browser, &new.browser) {
plan.hot_actions.push(HotAction::ReloadBrowserConfig);
}
if field_changed(&old.approval, &new.approval) {
plan.hot_actions.push(HotAction::UpdateApprovalPolicy);
}
if old.max_cron_jobs != new.max_cron_jobs {
plan.hot_actions.push(HotAction::UpdateCronConfig);
}
if field_changed(&old.webhook_triggers, &new.webhook_triggers) {
plan.hot_actions.push(HotAction::UpdateWebhookConfig);
}
if field_changed(&old.extensions, &new.extensions) {
plan.hot_actions.push(HotAction::ReloadExtensions);
}
if field_changed(&old.mcp_servers, &new.mcp_servers) {
plan.hot_actions.push(HotAction::ReloadMcpServers);
}
if field_changed(&old.a2a, &new.a2a) {
plan.hot_actions.push(HotAction::ReloadA2aConfig);
}
if field_changed(&old.fallback_providers, &new.fallback_providers) {
plan.hot_actions.push(HotAction::ReloadFallbackProviders);
}
if field_changed(&old.provider_urls, &new.provider_urls) {
plan.hot_actions.push(HotAction::ReloadProviderUrls);
}
// ----- No-op fields -----
if old.log_level != new.log_level {
plan.noop_changes
.push(format!("log_level: {} -> {}", old.log_level, new.log_level));
}
if old.language != new.language {
plan.noop_changes
.push(format!("language: {} -> {}", old.language, new.language));
}
if old.mode != new.mode {
plan.noop_changes
.push(format!("mode: {:?} -> {:?}", old.mode, new.mode));
}
plan
}
// ---------------------------------------------------------------------------
// validate_config_for_reload
// ---------------------------------------------------------------------------
/// Validate a new config before applying it.
///
/// Returns `Ok(())` if the config passes basic sanity checks, or `Err` with
/// a list of human-readable error messages.
pub fn validate_config_for_reload(config: &KernelConfig) -> Result<(), Vec<String>> {
let mut errors = Vec::new();
if config.api_listen.is_empty() {
errors.push("api_listen cannot be empty".to_string());
}
if config.max_cron_jobs > 10_000 {
errors.push("max_cron_jobs exceeds reasonable limit (10000)".to_string());
}
// Validate approval policy
if let Err(e) = config.approval.validate() {
errors.push(format!("approval policy: {e}"));
}
// Network config: if network is enabled, shared_secret must be set
if config.network_enabled && config.network.shared_secret.is_empty() {
errors.push("network_enabled is true but network.shared_secret is empty".to_string());
}
if errors.is_empty() {
Ok(())
} else {
Err(errors)
}
}
// ---------------------------------------------------------------------------
// should_reload — convenience helper for the reload mode
// ---------------------------------------------------------------------------
/// Given the configured [`ReloadMode`] and a [`ReloadPlan`], decide whether
/// the caller should apply hot actions.
///
/// Returns `true` if hot-reload actions should be applied.
pub fn should_apply_hot(mode: ReloadMode, plan: &ReloadPlan) -> bool {
match mode {
ReloadMode::Off => false,
ReloadMode::Restart => false, // caller must do a full restart
ReloadMode::Hot => !plan.hot_actions.is_empty(),
ReloadMode::Hybrid => !plan.hot_actions.is_empty(),
}
}
// ===========================================================================
// Tests
// ===========================================================================
#[cfg(test)]
mod tests {
use super::*;
use openfang_types::config::KernelConfig;
/// Helper: create a default config for diffing.
fn default_cfg() -> KernelConfig {
KernelConfig::default()
}
// -----------------------------------------------------------------------
// Plan detection tests
// -----------------------------------------------------------------------
#[test]
fn test_no_changes_detected() {
let a = default_cfg();
let b = default_cfg();
let plan = build_reload_plan(&a, &b);
assert!(!plan.has_changes());
assert!(!plan.restart_required);
assert!(plan.hot_actions.is_empty());
assert!(plan.noop_changes.is_empty());
}
#[test]
fn test_api_listen_requires_restart() {
let a = default_cfg();
let mut b = default_cfg();
b.api_listen = "0.0.0.0:8080".to_string();
let plan = build_reload_plan(&a, &b);
assert!(plan.restart_required);
assert!(plan
.restart_reasons
.iter()
.any(|r| r.contains("api_listen")));
}
#[test]
fn test_api_key_requires_restart() {
let a = default_cfg();
let mut b = default_cfg();
b.api_key = "super-secret-key".to_string();
let plan = build_reload_plan(&a, &b);
assert!(plan.restart_required);
assert!(plan.restart_reasons.iter().any(|r| r.contains("api_key")));
}
#[test]
fn test_network_requires_restart() {
let a = default_cfg();
let mut b = default_cfg();
b.network_enabled = true;
let plan = build_reload_plan(&a, &b);
assert!(plan.restart_required);
assert!(plan
.restart_reasons
.iter()
.any(|r| r.contains("network_enabled")));
}
#[test]
fn test_network_config_requires_restart() {
let a = default_cfg();
let mut b = default_cfg();
b.network.shared_secret = "new-secret".to_string();
let plan = build_reload_plan(&a, &b);
assert!(plan.restart_required);
assert!(plan
.restart_reasons
.iter()
.any(|r| r.contains("network config")));
}
#[test]
fn test_memory_config_requires_restart() {
let a = default_cfg();
let mut b = default_cfg();
b.memory.consolidation_threshold = 99_999;
let plan = build_reload_plan(&a, &b);
assert!(plan.restart_required);
assert!(plan
.restart_reasons
.iter()
.any(|r| r.contains("memory config")));
}
#[test]
fn test_default_model_requires_restart() {
let a = default_cfg();
let mut b = default_cfg();
b.default_model.model = "gpt-4".to_string();
let plan = build_reload_plan(&a, &b);
assert!(plan.restart_required);
assert!(plan
.restart_reasons
.iter()
.any(|r| r.contains("default_model")));
}
// -----------------------------------------------------------------------
// Hot-reload tests
// -----------------------------------------------------------------------
#[test]
fn test_channels_hot_reload() {
let a = default_cfg();
let mut b = default_cfg();
// Change the channels config by adding a Telegram config
b.channels.telegram = Some(openfang_types::config::TelegramConfig {
bot_token_env: "TG_TOKEN".to_string(),
..Default::default()
});
let plan = build_reload_plan(&a, &b);
assert!(!plan.restart_required);
assert!(plan.hot_actions.contains(&HotAction::ReloadChannels));
}
#[test]
fn test_usage_footer_hot_reload() {
use openfang_types::config::UsageFooterMode;
let a = default_cfg();
let mut b = default_cfg();
b.usage_footer = UsageFooterMode::Off;
let plan = build_reload_plan(&a, &b);
assert!(!plan.restart_required);
assert!(plan.hot_actions.contains(&HotAction::UpdateUsageFooter));
}
#[test]
fn test_max_cron_jobs_hot_reload() {
let a = default_cfg();
let mut b = default_cfg();
b.max_cron_jobs = 1000;
let plan = build_reload_plan(&a, &b);
assert!(!plan.restart_required);
assert!(plan.hot_actions.contains(&HotAction::UpdateCronConfig));
}
#[test]
fn test_extensions_hot_reload() {
let a = default_cfg();
let mut b = default_cfg();
b.extensions.reconnect_max_attempts = 20;
let plan = build_reload_plan(&a, &b);
assert!(!plan.restart_required);
assert!(plan.hot_actions.contains(&HotAction::ReloadExtensions));
}
#[test]
fn test_provider_urls_hot_reload() {
let a = default_cfg();
let mut b = default_cfg();
b.provider_urls
.insert("ollama".to_string(), "http://10.0.0.5:11434/v1".to_string());
let plan = build_reload_plan(&a, &b);
assert!(!plan.restart_required);
assert!(plan.hot_actions.contains(&HotAction::ReloadProviderUrls));
}
// -----------------------------------------------------------------------
// Mixed changes
// -----------------------------------------------------------------------
#[test]
fn test_mixed_changes() {
use openfang_types::config::UsageFooterMode;
let a = default_cfg();
let mut b = default_cfg();
// Restart-required
b.api_listen = "0.0.0.0:9999".to_string();
// Hot-reloadable
b.usage_footer = UsageFooterMode::Tokens;
b.max_cron_jobs = 100;
// No-op
b.log_level = "debug".to_string();
let plan = build_reload_plan(&a, &b);
assert!(plan.restart_required);
assert!(plan.has_changes());
// Hot actions are still collected even if restart is required,
// so the caller knows what will need re-initialization after restart.
assert!(plan.hot_actions.contains(&HotAction::UpdateUsageFooter));
assert!(plan.hot_actions.contains(&HotAction::UpdateCronConfig));
assert!(plan.noop_changes.iter().any(|c| c.contains("log_level")));
}
// -----------------------------------------------------------------------
// No-op changes
// -----------------------------------------------------------------------
#[test]
fn test_noop_changes() {
use openfang_types::config::KernelMode;
let a = default_cfg();
let mut b = default_cfg();
b.log_level = "debug".to_string();
b.language = "de".to_string();
b.mode = KernelMode::Dev;
let plan = build_reload_plan(&a, &b);
assert!(!plan.restart_required);
assert!(plan.hot_actions.is_empty());
assert_eq!(plan.noop_changes.len(), 3);
assert!(plan.noop_changes.iter().any(|c| c.contains("log_level")));
assert!(plan.noop_changes.iter().any(|c| c.contains("language")));
assert!(plan.noop_changes.iter().any(|c| c.contains("mode")));
}
// -----------------------------------------------------------------------
// has_changes / is_hot_reloadable helpers
// -----------------------------------------------------------------------
#[test]
fn test_has_changes() {
// No changes
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![],
noop_changes: vec![],
};
assert!(!plan.has_changes());
// Only noop
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![],
noop_changes: vec!["log_level: info -> debug".to_string()],
};
assert!(plan.has_changes());
// Only hot
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![HotAction::UpdateCronConfig],
noop_changes: vec![],
};
assert!(plan.has_changes());
// Only restart
let plan = ReloadPlan {
restart_required: true,
restart_reasons: vec!["api_listen changed".to_string()],
hot_actions: vec![],
noop_changes: vec![],
};
assert!(plan.has_changes());
}
#[test]
fn test_is_hot_reloadable() {
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![HotAction::ReloadChannels],
noop_changes: vec![],
};
assert!(plan.is_hot_reloadable());
let plan = ReloadPlan {
restart_required: true,
restart_reasons: vec!["api_listen changed".to_string()],
hot_actions: vec![HotAction::ReloadChannels],
noop_changes: vec![],
};
assert!(!plan.is_hot_reloadable());
}
// -----------------------------------------------------------------------
// Validation tests
// -----------------------------------------------------------------------
#[test]
fn test_validate_config_for_reload_valid() {
let config = default_cfg();
assert!(validate_config_for_reload(&config).is_ok());
}
#[test]
fn test_validate_config_for_reload_invalid() {
// Empty api_listen
let mut config = default_cfg();
config.api_listen = String::new();
let err = validate_config_for_reload(&config).unwrap_err();
assert!(err.iter().any(|e| e.contains("api_listen")));
// Excessive max_cron_jobs
let mut config = default_cfg();
config.max_cron_jobs = 100_000;
let err = validate_config_for_reload(&config).unwrap_err();
assert!(err.iter().any(|e| e.contains("max_cron_jobs")));
}
#[test]
fn test_validate_network_enabled_no_secret() {
let mut config = default_cfg();
config.network_enabled = true;
config.network.shared_secret = String::new();
let err = validate_config_for_reload(&config).unwrap_err();
assert!(err.iter().any(|e| e.contains("shared_secret")));
}
// -----------------------------------------------------------------------
// should_apply_hot
// -----------------------------------------------------------------------
#[test]
fn test_should_apply_hot_off() {
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![HotAction::ReloadChannels],
noop_changes: vec![],
};
assert!(!should_apply_hot(ReloadMode::Off, &plan));
}
#[test]
fn test_should_apply_hot_restart_mode() {
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![HotAction::ReloadChannels],
noop_changes: vec![],
};
assert!(!should_apply_hot(ReloadMode::Restart, &plan));
}
#[test]
fn test_should_apply_hot_hybrid() {
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![HotAction::ReloadChannels],
noop_changes: vec![],
};
assert!(should_apply_hot(ReloadMode::Hybrid, &plan));
assert!(should_apply_hot(ReloadMode::Hot, &plan));
}
#[test]
fn test_should_apply_hot_empty() {
let plan = ReloadPlan {
restart_required: false,
restart_reasons: vec![],
hot_actions: vec![],
noop_changes: vec![],
};
assert!(!should_apply_hot(ReloadMode::Hybrid, &plan));
}
}